Skip to content

Set permissions to close milestones for GoReleaser #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2023
Merged

Set permissions to close milestones for GoReleaser #1405

merged 1 commit into from
Dec 18, 2023

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented Dec 18, 2023 •
edited
Loading

Proposed changes

Problem: GoReleaser cant close milestones on release because it doesn't have the right permissions.

Solution: Add write permissions for issues in the binary job so GoReleaser is able to close milestones.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome
Set permissions to close milestones for GoReleaser
c115f02 
Problem: GoReleaser cant close milestones on release because it doesn't
have the right permissions.

Solution: Add write permissions for issues in the binary job so
GoReleaser is able to close milestones.
@lucacome lucacome requested a review from a team as a code owner December 18, 2023 20:55
@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 18, 2023
@lucacome lucacome merged commit 5ef8479 into nginx:main Dec 18, 2023
@lucacome lucacome deleted the chore/goreleaser-permissions branch December 18, 2023 23:33
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
@miledxz
Set permissions to close milestones for GoReleaser (nginx#1405)
fe1fcd5 
Problem: GoReleaser cant close milestones on release because it doesn't
have the right permissions.

Solution: Add write permissions for issues in the binary job so
GoReleaser is able to close milestones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

@bjee19 bjee19 bjee19 approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucacome @sjberman @kate-osborn @bjee19